Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License: simplify models & optimize Factory & fix Expression validator #247

Closed
jkowalleck opened this issue Mar 6, 2023 · 0 comments · Fixed by #249
Closed

License: simplify models & optimize Factory & fix Expression validator #247

jkowalleck opened this issue Mar 6, 2023 · 0 comments · Fixed by #249
Assignees
Labels
breaking change enhancement New feature or request
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Mar 6, 2023

GOAL:

  • improve SPDX license expression detection -- incorporate https://packagist.org/packages/composer/spdx-licenses
  • have the license model just take what they are given - no validation inside
  • factory may validate/check and generate the correct data types: preferred order: SpdxID, Expression, NamedLicense as fallback.
  • normalizers need to check for valid SPDX license id, as the model does no longer assert this.
@jkowalleck jkowalleck added this to the v2 milestone Mar 6, 2023
@jkowalleck jkowalleck changed the title optimize LicenseFactory optimize LicenseFactory & LicenseExpression validator Mar 6, 2023
@jkowalleck jkowalleck added enhancement New feature or request idea labels Mar 6, 2023
@jkowalleck jkowalleck removed the idea label Mar 8, 2023
@jkowalleck jkowalleck changed the title optimize LicenseFactory & LicenseExpression validator License: simplify models & optimize LicenseFactor & fix LicenseExpression validator Mar 8, 2023
@jkowalleck jkowalleck changed the title License: simplify models & optimize LicenseFactor & fix LicenseExpression validator License: simplify models & optimize Factory & fix Expression validator Mar 8, 2023
@jkowalleck jkowalleck self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant