-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cyctl
: implement a create method for Modules
#290
Comments
@petar-cvit, I've implemented a command for creating TemplateStore custom resources: cyctl create template NAME --repo='https://github.com/cyclops-ui/templates' --path='/path' --version='main' I’m considering adding namespace flags as well. Currently, the What are your thoughts on this? |
Nice! The version flag does not need to default to anything. There is already logic for defaulting when the version is not specified in the controller, so a template without a version is completely valid. Can you split this issue into multiple smaller ones since Module creation could be a bigger chunk of work then the creation TemplateStore CR? You can open a new issue for the creation of templates and I can assign you to it |
cyctl
: implement a create method for Modules / TemplateStore / TemplateAuthRulescyctl
: implement a create method for Modules
I was wondering if we could have a command like, cyctl create module NAME -f values.yaml since the values are not consistent. |
you are thinking about |
the values.yaml will contain this values:
general:
environment:
ENVIRONMENT: production
image: nginx
version: 1.14.2
name: nginx-app
networking:
expose: true
port: 8080
scaling:
replicas: 2
resources:
cpu: 0.1
memory: 0.01 and the complete command would look something like this cyctl create module NAME -f values.yaml \
--repo 'github.com/github/demo' \
--path '/path/to/charts' \
--version 'main' |
Hey @siddhantprateek, sorry for the delay, I forgot to respond. Yeah, this looks good, except that I would leave out values from the file, but all the other parts look good! |
No issues, i was working on cerbos authorization part until that, i'll update the suggested changes for this |
Is your feature request related to a problem? Please describe.
We need to implement a create method for Modules, TemplateStore, TemplateAuthRules custom resource. The command structure should be:
Would you like to work on this issue?
Yes
The text was updated successfully, but these errors were encountered: