Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Cyclops xml recipe system #17

Closed
rubensworks opened this issue Jan 22, 2016 · 3 comments
Closed

Compatibility with Cyclops xml recipe system #17

rubensworks opened this issue Jan 22, 2016 · 3 comments
Assignees
Labels

Comments

@rubensworks
Copy link
Member

Auto-generate predefined items for all registered fluid groups (like https://github.com/CyclopsMC/EvilCraft/blob/master-1.7/src/main/resources/assets/evilcraft/recipes/shaped.xml#L493-L495).
Some other way of defining those items might be possible as well, like for example an extension to the xml recipe system for adding NBT tags.

@immortaleeb
Copy link
Contributor

I tried this in a separate branch: https://github.com/CyclopsMC/FluidConverters/tree/recipes
The biggest problem that keeps it from working is the fact that fluid groups are loaded on postInit, while recipes are loaded somewhere in on Init.

The way I see it there are 2 possible fixes:

  1. Move parsing of fluid group configs before recipe loading, and only load the actual fluid groups (i.e. find fluids in the registry) after all recipes are loaded. The problem is that this could potentially register recipes for fluid converters that appear to be invalid fluid converters later due to e.g. the fluids in the fluid elements being ignored.
  2. Ignore recipe loading in init step and/or (re)trigger recipe loading after postInit (i.e. after loading the fluid groups).

@rubensworks
Copy link
Member Author

I would try to move recipes loading to postInit (on CyclopsCore level).
Before making the actual change, look if this doesn't break anything, EvilCraft should be the first mod to show any signs of breakage.

immortaleeb added a commit that referenced this issue Feb 3, 2016
Fluid groups used to be loaded in postInit, but since fluids are mostly
registered in preInit, they can actually be loaded during init.

This should also fix the issue of custom recipes being loaded before
the fluid groups are registered, see issue #17.
@immortaleeb
Copy link
Contributor

Added in 6174b9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants