Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newer test classes to skip if cyclus does not have COIN #601

Merged
merged 2 commits into from
May 1, 2024

Conversation

bennibbelink
Copy link
Contributor

In a handful of places the method being used to skip tests is different than the standard method (skip_if_dont_allow_milps()). This has not been tested in CI since we always install cyclus and cycamore with the --allow-milps flag and COIN. I tested this locally to confirm that the correct tests are now skipped when cyclus and cycamore are installed without MILPS support - I encourage any reviewers to test locally as well

If we wish to hold this back until CI is in place to test, that is fine with me. Currently all of our distribution methods build cyclus and cycamore with COIN support so this might not be super pressing

Copy link

github-actions bot commented Apr 30, 2024

Build Status Report - a783156 - 2024-04-30 13:56:59 -0500

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

@gonuke
Copy link
Member

gonuke commented May 1, 2024

I tested with and without this patch and it solved the problem. Thanks @bennibbelink

@gonuke gonuke merged commit 35adbce into cyclus:main May 1, 2024
10 checks passed
@bennibbelink bennibbelink deleted the skip-coin-pytests branch May 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants