Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve load wallet error handling #49

Closed
cygnet3 opened this issue Sep 7, 2024 · 0 comments · Fixed by #55
Closed

Improve load wallet error handling #49

cygnet3 opened this issue Sep 7, 2024 · 0 comments · Fixed by #55
Labels
enhancement New feature or request error handling

Comments

@cygnet3
Copy link
Owner

cygnet3 commented Sep 7, 2024

Right now the load wallet flow is not very future-proof. On startup, we try to read the wallet file. If we fail (either because no wallet exists, or we are unable to read the file), we take the user to the 'create wallet' screen.
This effectively means that if we error for whatever reason, to a user, it will look like the wallet has been deleted.

We should improve this flow.

After reading the wallet file:

  • if loaded successfully, take the user to the main (wallet overview) screen
  • if wallet = null, take user to 'create wallet' screen.
  • if wallet = error, take user to a very simple error page with only the piece of text 'wallet loading failed'.

We should think more properly about how to deal with 'failing to load' state, but for now this is good enough.

@cygnet3 cygnet3 added the enhancement New feature or request label Sep 7, 2024
@cygnet3 cygnet3 changed the title Improve load wallet flow Improve load wallet error handling Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request error handling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant