Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch mode-split chart to horizontal stacked bar chart #111

Closed
Siequnu opened this issue Feb 25, 2021 · 8 comments
Closed

Switch mode-split chart to horizontal stacked bar chart #111

Siequnu opened this issue Feb 25, 2021 · 8 comments

Comments

@Siequnu
Copy link
Collaborator

Siequnu commented Feb 25, 2021

mode-split-base

It's currently a vertical stacked bar chart — can we change this to horizontal?
This will increase the legibility in horizontal layouts and allow me to expand the size.

Screenshot 2021-02-25 at 23 52 30

@Robinlovelace
Copy link
Contributor

It's currently a vertical stacked bar chart — can we change this to horizontal?

Could do but I'm not convinced, easier to interpret as vertical stacked graph. Also I want to focus on MVP issues and this isn't one so skeptical that this is a good use of time at this stage. Good to see updated colours, which is MVP:

image

Although I think the colourscheme needs a bit more thinking: motorised modes tending towards red and active modes towards cooler blue/green colour and some grouping would work well I think.

@Siequnu
Copy link
Collaborator Author

Siequnu commented Feb 25, 2021

This isn't an updated colour scheme — it's simply an inverted image to match the white background with the site background, until the graphs can be produced with the background and colour I mentioned here.

Background colour should be #434343, or transparent which would be even better. Text colour ideally white as we will be predominantly using a darker background. I am currently using a few tricks with the auto generated graphs (see the updated site) to make them fit better into the colour scheme by inverting the colours, but that of course flips the colour scales as well.

@Robinlovelace
Copy link
Contributor

This isn't an updated colour scheme — it's simply an inverted image to match the white background with the site background, until the graphs can be produced with the background and colour I mentioned here.

OK but you see the need to decide colours for each mode before generating the plots?

Of the colourschemes I've seen so far of plots generated using code in this project I think these two are the most viable (I have a mild preference for the top one but imagine we can do better than that):

image

image

@Robinlovelace
Copy link
Contributor

Moving discussion of colourschemes for modes to a new issue, this is going off topic.

@mvl22
Copy link
Contributor

mvl22 commented Feb 25, 2021

Could do but I'm not convinced, easier to interpret as vertical stacked graph.

Bear in mind that we have a landscape-shaped space to put a chart in. Therefore, the bars will be flattened downwards, meaning that e.g. 10% cycling will appear with a very thin bar, making differences hard to see. A left/right chart would probably show the differences more clearly.

I'd welcome at least seeing an example of the chart to understand why a vertical chart is supposedly better. To me that third example just above shows exactly the problem - all I can tell is that walking and cycling is vaguely not really present.

@Robinlovelace
Copy link
Contributor

If the proposal is to change the pngs, which are planned to be implemented as JS vector graphics in any case, I think the onus is on the person proposing the change to provide a good reason. More important and much close to MVP territory is aspect ratios. What is best: 4:3, 1:1, or what? Numbers and images can speak louder than words at this stage. Mock-ups and info on pixels/sizes v. welcome..

@Siequnu
Copy link
Collaborator Author

Siequnu commented Feb 26, 2021

Generally, we have landscape screens, and landscape spaces in our design for charts, so creating the chart in some kind of landscape format is fine. Especially the legend should be on one of the sides, rather than at the bottom.

@Robinlovelace
Copy link
Contributor

More specific guidance on the graphics such as aspect ratios and pixel counts would be appreciated. Given plans to generate vector versions of the graphs closing here in favour of cyipt/actdev-ui#29. Happy to revisit this if a firm decision is made. Generally best to keep issues specific and actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants