feat: model.sync add force/alter option #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
reviewed
Nov 3, 2021
cyjake
reviewed
Nov 3, 2021
src/realm.js
Outdated
| if (!this.connected) await this.connect(); | ||
| const { models } = this; | ||
|
|
||
| for (const model of Object.values(models)) { | ||
| await model.sync(); | ||
| await model.sync(optins); |
|
@xudafeng this pr breaks yuque-desktop, I think it should be planned in v2 release. Perhaps 2022.1.1 is a good time? |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 42 42
Lines 3096 3101 +5
=======================================
+ Hits 3011 3016 +5
Misses 85 85
Continue to review full report at Codecov.
|
cyjake
reviewed
Nov 3, 2021
| @@ -135,7 +135,7 @@ describe('=> Table definitions', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('=> Bone.sync()', () => { | |||
| describe.only('=> Bone.sync()', () => { | |||
|
will be released at v2.x milestone |
fengmk2
reviewed
Dec 5, 2021
| id: DataTypes.BIGINT, | ||
| name: DataTypes.STRING, | ||
| }); | ||
| await realm.sync({ alter: true }); |
cyjake
pushed a commit
that referenced
this pull request
Jan 4, 2022
* feat: model.sync add force/alter option * fix: integration test case * fix: typo and reminder * fix: remove .only Co-authored-by: mijiu.zc <mijiu.zc@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #151