Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDLF inherits CoolingModelReader #7

Closed
cylammarco opened this issue Feb 18, 2022 · 0 comments
Closed

WDLF inherits CoolingModelReader #7

cylammarco opened this issue Feb 18, 2022 · 0 comments
Assignees
@cylammarco
Labels
enhancement New feature or request

Comments

@cylammarco
Copy link
Owner

Currently, WDLF holds an instance of CoolingModelReader. It should be inheriting it to make the future extensions of the package easier without needing to write a wrapper function for every new method added.
@cylammarco cylammarco added the enhancement New feature or request label Feb 18, 2022
@cylammarco cylammarco self-assigned this Feb 18, 2022
cylammarco added a commit that referenced this issue Feb 19, 2022
@cylammarco
Merged the 4 diagnostic plots into a single one in the WDLF(). Fixed …
4d9aedc 
…and Close #5, #6, and #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cylammarco cylammarco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cylammarco