Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

add configurable-http-proxy to recipe #9

Closed
kinow opened this issue Sep 6, 2019 · 5 comments · Fixed by #11
Closed

add configurable-http-proxy to recipe #9

kinow opened this issue Sep 6, 2019 · 5 comments · Fixed by #11
Assignees
Milestone

Comments

@kinow
Copy link
Member

kinow commented Sep 6, 2019

From Riot discussion. I think I forgot to include it, and it worked only because I had installed it globally before.

@hjoliver
Copy link
Member

Yes I think we should include it in the recipe.

@hjoliver
Copy link
Member

(need a basic system that works out of the box)

@kinow kinow self-assigned this Sep 16, 2019
@kinow kinow added this to the 8.0a1 milestone Sep 16, 2019
@kinow
Copy link
Member Author

kinow commented Sep 17, 2019

Output of conda search configurable-http-proxy:

$ conda search configurable-http-proxy
Loading channels: done
# Name                       Version           Build  Channel             
configurable-http-proxy           1.2.0               0  conda-forge         
configurable-http-proxy           1.3.0               0  conda-forge         
configurable-http-proxy           1.3.0               1  conda-forge         
configurable-http-proxy           1.3.1               0  conda-forge         
configurable-http-proxy           2.0.0               0  conda-forge         
configurable-http-proxy           2.0.1               0  conda-forge         
configurable-http-proxy           2.0.2               0  conda-forge         
configurable-http-proxy           2.0.4               0  conda-forge         
configurable-http-proxy           3.0.0               0  conda-forge         
configurable-http-proxy           3.1.0               0  conda-forge         
configurable-http-proxy           3.1.0         node6_1  conda-forge         
configurable-http-proxy           3.1.0         node6_2  conda-forge         
configurable-http-proxy           3.1.0         node8_1  conda-forge         
configurable-http-proxy           4.0.1         node6_0  conda-forge         
configurable-http-proxy           4.0.1         node6_0  pkgs/main           
configurable-http-proxy           4.1.0        node11_1  conda-forge         
configurable-http-proxy           4.1.0         node6_0  conda-forge

So will occam razor, simply adding it to the recipe and see what happens.

@kinow
Copy link
Member Author

kinow commented Sep 17, 2019

My version is 4.1.0.

$ configurable-http-proxy -V
4.1.0

And looks like there are two 4.1.0 version in the output of conda search. So will try using 4.1.* or similar syntax, to make sure users get the same version in their conda environments.

@kinow
Copy link
Member Author

kinow commented Sep 17, 2019

Tested by adding the new requirement:

requirements:
  host:
    - python >=3.7
  run:
    - cylc-flow==8.0a1
    - cylc-uiserver==1.0
    - python >=3.7
    - configurable-http-proxy >= 4.1

And a test command:

  commands:
    - cylc --version
    - cylc-uiserver --help
    - configurable-http-proxy -V

Then

$ conda create -n cylc1
$ conda activate cylc1
$ conda build .

It failed, but conda is nice enough to tell you what could be wrong 🙂 👍

TEST END: /home/kinow/anaconda3/conda-bld/linux-64/cylc-uiserver-1.0-py37_0.tar.bz2
Renaming work directory,  /home/kinow/anaconda3/conda-bld/cylc-uiserver_1568688261446/work  to  /home/kinow/anaconda3/conda-bld/cylc-uiserver_1568688261446/work_moved_cylc-uiserver-1.0-py37_0_linux-64_main_build_loop
Error: bad character '>=' in package version dependency 'configurable-http-proxy'
Perhaps you meant 'configurable-http-proxy >=4.1'

Once fixed, conda build . passed successfully. Final step was to install it:

$ conda install --use-local cylc

image

Then did the one command trick described in the README to test the whole set up:

$ jupyterhub --JupyterHub.spawner_class="jupyterhub.spawner.LocalProcessSpawner" --Spawner.args="['-s', '${CONDA_PREFIX}/work/cylc-ui']" --Spawner.cmd="cylc-uiserver" --JupyterHub.logo_file="${CONDA_PREFIX}/work/cylc-ui/img/logo.png"

And it worked. So final step was:

$ which configurable-http-proxy 
/home/kinow/anaconda3/envs/cylc1/bin/configurable-http-proxy

Which confirms the installation worked with no issues 🎉 Preparing PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants