Turn off "against source" mode after validation step of Cylc VR #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColemanTom
reviewed
Jul 11, 2024
MetRonnie
reviewed
Jul 11, 2024
wxtim
force-pushed
the
fix.cylc_vr_doesnt_match_cylc_restart
branch
from
959145c
to
9c11d53
Compare
wxtim
changed the title
wxtim
changed the title
|
I have noticed currently on 8.3.x: $ cylc validate myflow
Valid for cylc-8.3.3.dev
$ cylc validate myflow --mode simulation
PointParsingError: Incompatible value for <class 'cylc.flow.cycling.iso8601.ISO8601Point'>: alp: Invalid ISO 8601 date representation: alp |
|
How have you managed to include Ctrl+M in a commit message? 🤯 |
MetRonnie
reviewed
Jul 15, 2024
I haven't - it's something to do with me using a-a-grave |
wxtim
force-pushed
the
fix.cylc_vr_doesnt_match_cylc_restart
branch
2 times, most recently
from
3006a97
to
c0f5308
Compare
MetRonnie
reviewed
Jul 18, 2024
MetRonnie
reviewed
Jul 18, 2024
remove the --against-source option from cylc vr - it should _always_ be true test that Cylc VR unsets the --against-source mode after validation. response to review: delattr add test for validate --mode=live,sim,dummy Apply suggestions from code review Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> response to review Update tests/functional/cylc-combination-scripts/08-vr-against-src.t Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
wxtim
force-pushed
the
fix.cylc_vr_doesnt_match_cylc_restart
branch
from
02ea907
to
dbcf1cc
Compare
markgrahamdawson
approved these changes
Jul 23, 2024
MetRonnie
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cylc vron a stopped workflow doesn't pass all arguments through tocylc play#6209 which can be manually tested in the hope of getting it in to 8.3.2.cylc vr --against-sourcebecause it makes no sense - we always want to run the validate step of VR against source.cylc validate.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.