Fcm make fix for remote and subshell platforms #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Mar 16, 2022
MetRonnie
reviewed
Mar 18, 2022
| def get_platform_from_task_def( | ||
| flow: str, task: str | ||
| ) -> Dict[str, Any]: | ||
| def get_platform_from_task_def(flow: str, task: str) -> Dict[str, Any]: | ||
| """Return the platform dictionary for a particular task. | ||
|
|
||
| Uses the flow definition - designed to be used with tasks |
There was a problem hiding this comment.
I think the docstring could be updated to mention that it evaluates any subshell defined platform/hosts
| from cylc.flow.id_cli import parse_id | ||
| from cylc.flow.platforms import ( | ||
| HOST_REC_COMMAND, |
There was a problem hiding this comment.
This allows backticks, was that desired?
There was a problem hiding this comment.
This is only for the old [remote]host syntax which I think we supported at Cylc 7.
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
MetRonnie
approved these changes
Mar 21, 2022
t/rose-task-run/08-app-fcm-make/ From a quick glance add the following to the [template variables]
HOST="name your remote host"You will also need an fcm wrapper in |
oliver-sanders
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to: metomi/rose#2557
Again credit to @wxtim for pair programming this.
These changes close metomi/rose#2553
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg- None to apply.