Fcm make fix for remote and subshell platforms #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify make2 task to use host specfied by a command - Add a single step make on a remote host
6 tasks
|
Note that the tests will fail on GH Actions as it requires cylc/cylc-rose#120. These should pass locally. Update: refactored so now not the case. |
MetRonnie
approved these changes
Mar 21, 2022
oliver-sanders
approved these changes
Mar 21, 2022
oliver-sanders
pushed a commit
to cylc/cylc-rose
that referenced
this pull request
Mar 21, 2022
fcm_make fix for remote and subshell platforms * see metomi/rose#2557
|
Merged the cylc-rose branch, re-running the tests. |
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2553
Requires sibling cylc-rose to be checked out (cylc/cylc-rose#120).
Credit to @wxtim for pairing this.