-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task pool: assign previous state to transient task proxy objects #6412
Comments
This completes the succeeded output of If there are any tasks downstream of
This completes the failed output of If there are any tasks downstream of At this point
This completes the succeeded output of (No downstream children will spawn because that would already have happened in this flow, the first time the output got completed.) So ... restoring the bug label! |
(Issue probably needs to be moved to cylc/cylc-flow ... this is presumably a scheduler data store problem.) |
I wasn't entirely sure how to label this I admit. It feels like a very odd behaviour to do, but I did do it whilst monkey testing some things so I thought I should report it in case it is a bug. |
I think the root cause of this issue is the "transient task proxy" objects that are used by task pool in some cases. When we create a "transient" task proxy, we extract any previously completed outputs from the DB, however, we do not retrieve the previous task status, instead defaulting to "waiting". |
Taking a look at the loading of the outputs: cylc-flow/cylc/flow/task_pool.py Lines 1634 to 1635 in 62fb15b
@hjoliver, shouldn't that function be filtering entries by flow number(s)? |
Yeah I think you're right. |
Description
Doing
cylc set
in order (at least of)succeeded, failed, succeeded
gives incorrect symbol colouring. The status of outputs appears correct in cylc show, but incorrect (maybe?) in UI.Reproducible Example
NOTE: Look at UI symbols in between each
cylc set
command, and on CLI to see the inconsistency.cylc set workflow//cycle/task
(circle is fully coloured in)cylc set -o failed workflow//cycle/task
(circle now has a cross in it)cylc set workflow//cycle/task
(circle has no symbol or colouring)cylc set workflow//cycle/task
(circle still has no symbol or colouring)Expected Behaviour
I think it should be showing as fully coloured in. However, I recognise that it is perhaps in a confused state.
The text was updated successfully, but these errors were encountered: