simple tree: bare-bones tree view for documentation purposes #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
* A new bare-bones live tree view not available in production mode. * Indended to serve as documentation and a guide for future view development.
oliver-sanders
force-pushed
the
simple-tree
branch
from
74a643d
to
1cb0769
Compare
oliver-sanders
commented
Dec 1, 2022
oliver-sanders
commented
Dec 1, 2022
src/views/Workflow.vue
Outdated
Comment on lines
111
to
116
| if (this.environment !== 'PRODUCTION') { | ||
| // dynamically load development views that we don't want in production | ||
| import('@/views/SimpleTree').then((SimpleTreeView) => { | ||
| this.views.push(SimpleTreeView.default) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Reviewers: Please check that the SimpleTree is present when the UI is built in dev mode (i.e. build:watch) but not when run in production mode (i.e. build).
|
Rebased and ready. |
|
No tests for this ATM (functional documentation). Wouldn't object if anyone wanted to write one though... |
Resolved Conflicts: src/store/workflows.module.js src/views/Workspace.vue
|
@oliver-sanders - I've pushed a small conflict resolution commit (merge from master) to your branch. |
hjoliver
approved these changes
Apr 2, 2023
|
@MetRonnie or @wxtim - I'm sure this would be a quick review for one of you. |
MetRonnie
approved these changes
Apr 5, 2023
|
The only thing I might suggest is excluding the new file from code coverage? |
oliver-sanders
commented
Apr 24, 2023
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleTree: a simple view a functional documentation
development.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.