Simplify mutation menu #1775
Simplify mutation menu #1775
Conversation
There was a problem hiding this comment.
Looks good to me.
Spotted one issue in the graph view where opening the menu on different jobs didn't behave as elsewhere. Haven't checked this against master, however, it appears to be fixed with #1780
|
Latest change should make it immune to that kind of thing |
|
Fixed. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I've also renamed the |
There was a problem hiding this comment.
I found one "quirk" when a task disappears from the n-window and is removed from the view, any open menu will jump to the top-left of the screen (because the target node has been removed).
Would be beneficial if we could disable this behaviour, but the menu remains functional so not a biggie.
| :key="node.id" | ||
| v-click-outside="{ handler: onClickOutside, closeConditional: () => !dialog }" | ||
| class="c-mutation-menu elevation-10 overflow-y-auto" | ||
| max-height="90vh" |
There was a problem hiding this comment.
Tested with small windows, the default max-height behaviour appears to be sufficient.
By figuring out how to use
VMenubetter I was able to drop a fair amount of cruft.We were originally using
VMenubut through various attempts to get it to behave the way we want (e.g. #927, #1269) I ended up re-implementing some of the behaviour manually (e.g. click-outside behaviour).It turns out the key to using
VMenuand getting it to behave the way we want is not too difficult::targetprop - this allows Vuetify to take care of positioning relative to thec-data-interactiveelement that was clicked on:keyprop - this allows the menu to re-open when clicking betweenc-data-interactiveelements by using a unique identifier for each element (so Vue knows a different element has been clicked)Update: also renamed the
v-cylc-objectdirective tov-command-menuas that is more descriptive IMOCheck List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry not needed as invisible to users