-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent mutation menu closing when clicking on another task or cycle #927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 90.30% 90.57% +0.27%
==========================================
Files 92 92
Lines 2000 2005 +5
Branches 151 152 +1
==========================================
+ Hits 1806 1816 +10
+ Misses 168 163 -5
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
el.removeEventListener('show-mutations-menu', listener) | ||
el.removeEventListener('click', listener) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a mistake, the first arg should be the event that you're removing the listener for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, and works for me too.
I'll leave it for @wxtim to merge (sounds like he wants to look at the code more closely) [Oops wrong PR for that statement!]
These changes close #916
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.