Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New default pre_release(which = "next") #524

Merged
merged 3 commits into from
Sep 6, 2022
Merged

feat: New default pre_release(which = "next") #524

merged 3 commits into from
Sep 6, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 5, 2022

Fix #521

I did not add it to update_version() as in the end it seemed more logical not to.

@maelle maelle requested a review from krlmlr September 5, 2022 13:46
@krlmlr krlmlr changed the title feat: add "next" which value for pre_release() feat: New default pre_release(which = "next") Sep 6, 2022
@krlmlr krlmlr merged commit daa78c7 into main Sep 6, 2022
@krlmlr krlmlr deleted the next branch September 6, 2022 06:59
@krlmlr
Copy link
Contributor

krlmlr commented Sep 6, 2022

Thanks! I wonder why it seemed logical to not support bump_version(which = "next") . The asymmetry troubles me a tiny bit -- "next" is supported only by pre_release(), which doesn't support "pre-major" or "pre-minor" (of course) but these are supported by bump_version() . It would be less troublesome if pre_release() supported a subset of the possible which .

@maelle
Copy link
Member Author

maelle commented Sep 6, 2022

My thinking was that

  • if you want dev, that's the default in bump_version() anyway;
  • if you want major/minor/patch it means you are doing a release which we'd encourage to do with pre_release()? but it might be worth opening an issue as some packages aren't released on CRAN indeed.

@maelle maelle mentioned this pull request Sep 6, 2022
@krlmlr
Copy link
Contributor

krlmlr commented Sep 6, 2022

We still want users to be able to compose their own workflows with lower-level functions, bump_version("next") might be mildly useful in some corner cases. Not a priority though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add "next"
2 participants