Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove partial matching warning #579

Merged
merged 2 commits into from
Nov 10, 2022
Merged

fix: Remove partial matching warning #579

merged 2 commits into from
Nov 10, 2022

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Nov 10, 2022

Also use explicit assign.

@maelle
Copy link
Member

maelle commented Nov 10, 2022

Why use explicit assign by the way?

@krlmlr
Copy link
Contributor Author

krlmlr commented Nov 10, 2022

x <- if (...) isn't a pattern I typically use, it confused me a bit when refactoring.

@maelle
Copy link
Member

maelle commented Nov 10, 2022

👍

@maelle maelle merged commit 80de663 into main Nov 10, 2022
@maelle maelle deleted the b-pmatch branch November 10, 2022 09:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @maelle