fix: Increase timeout for npm-webpack-dev-server tests #22489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
AtofStryker
approved these changes
Jun 23, 2022
tbiethman
approved these changes
Jun 23, 2022
|
Because this change affects only one set of CI jobs, and they've passed cleanly on the first try (while completely failing today in many other branches), I'm going to merge this in without waiting for a completely green build so that I can move on and address other failing tests separately. |
tgriesser
added a commit
that referenced
this pull request
Jun 24, 2022
…esser/CLOUD-577-spec-list-display-latest-runs-batching * muaz/CLOUD-577-spec-list-display-latest-runs: fix: Update "Request Access" button state after requesting access (ACI) (#22499) feat: Support "Queued" latest run status (#22497) fix: remove ctx.cloud.reset in tests, handle infinite loop in stale results (#22483) chore: add reporter webpack to gulp watch script (#22386) fix: Increase timeout for npm-webpack-dev-server tests (#22489) fix: Time out unmatched prerequests in proxy to avoid leaking memory (#22462) fix: Sort results in findCrossOriginLogs test helper to deterministic (#22481) fix: memory leak caused by storing base64 encoded files recieved by CDP `Network.requestWillBeSent` (#22460) fix: Improve cross-origin cookie handling (#22320) feat: Add button to clear value from search fields (#22202) chore: Add test to verify settings panels are collapsed by default (#22382) fix: process_profiler follow up work for v10 (#22363) chore: Update Chrome (stable) to 103.0.5060.53 (#22441) refactor: use design system windicss config (#21503) chore: update readme logo (#22433) chore: Update Chrome (beta) to 103.0.5060.53 (#22351) chore: updating version (#22432) Trigger Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
No user facing changes.
Additional details
The system tests in
sourceRelativeWebpackModules.spec.tshave been extremely flaky the past few days, to the point where it's more "consistent failure" than it is "flake".It seems to be simply a timeout issue - the 10s we've allocated aren't enough to successfully yarn install all the dependencies for
webpack5_wds4-reactand similar system test projects.While I'd very much like to rewrite these tests so as not to take so long, there's no quick solution here and it would probably involve changing how we install system test dependencies entirely (or mocking them out not to actually install), something beyond the scope of my efforts at the moment.
Therefore, timeout increase. Green builds are super important.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?