-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process_profiler follow up work for v10 #22363
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -0,0 +1,28 @@ | |||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exports everything from before, less getServerPluginHandlers
which doesn't seem be used at this point.
} | ||
|
||
export const getPluginPid = () => { | ||
return getCtx().lifecycleManager.eventProcessPid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With type checking here, we shouldn't see similar regressions going forward.
@@ -208,7 +208,7 @@ export const _aggregateGroups = (processes: Process[]) => { | |||
export const _printGroupedProcesses = (groupTotals) => { | |||
const consoleBuffer = concatStream((buf) => { | |||
// get rid of trailing newline | |||
debugVerbose(String(buf).trim()) | |||
debug(String(buf).trim()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we intentionally updating this to debug rather than debugVerbose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we document this as being available with the non-verbose namespace: https://docs.cypress.io/guides/references/troubleshooting#Log-memory-and-CPU-usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!
…esser/CLOUD-577-spec-list-display-latest-runs-batching * muaz/CLOUD-577-spec-list-display-latest-runs: fix: Update "Request Access" button state after requesting access (ACI) (#22499) feat: Support "Queued" latest run status (#22497) fix: remove ctx.cloud.reset in tests, handle infinite loop in stale results (#22483) chore: add reporter webpack to gulp watch script (#22386) fix: Increase timeout for npm-webpack-dev-server tests (#22489) fix: Time out unmatched prerequests in proxy to avoid leaking memory (#22462) fix: Sort results in findCrossOriginLogs test helper to deterministic (#22481) fix: memory leak caused by storing base64 encoded files recieved by CDP `Network.requestWillBeSent` (#22460) fix: Improve cross-origin cookie handling (#22320) feat: Add button to clear value from search fields (#22202) chore: Add test to verify settings panels are collapsed by default (#22382) fix: process_profiler follow up work for v10 (#22363) chore: Update Chrome (stable) to 103.0.5060.53 (#22441) refactor: use design system windicss config (#21503) chore: update readme logo (#22433) chore: Update Chrome (beta) to 103.0.5060.53 (#22351) chore: updating version (#22432) Trigger Build
User facing changelog
Additional details
The plugin group had stopped working due to some of the called APIs in the ProjectLifecycleManager being removed. I added a few APIs to enable the profiler to once again access this process info and properly group it.
Steps to test
DEBUG=cypress:server:util:process_profiler
launchpad
), select testing typeHow has the user experience changed?
These changes align with our currently documented behavior.
PR Tasks
cypress-documentation
?type definitions
?