Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support "Queued" latest run status #22497

Conversation

mike-plummer
Copy link
Contributor

  • Update GQL schema
  • Add handling for UNCLAIMED status
  • Only show loading indicator in Latest Runs section on initial fetch

User facing changelog

Additional details

Steps to test

  1. Open project and log in to cloud
  2. Observe "latest run" data displays loading indicator on initial load of Specs Explorer
  3. Start recording of project run in another terminal
  4. Every 30 seconds app should poll for updated "latest run" data, observe that loading indicator is not shown during refetches
  5. Mouse over the currently-running spec's "latest run" column, observe tooltip with "Queued" status

How has the user experience changed?

Screen.Recording.2022-06-23.at.5.49.26.PM.mov

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2022

Thanks for taking the time to open a PR!

@mike-plummer mike-plummer changed the title Mikep/cloud 577 queued status Support "Queued" latest run status Jun 23, 2022
@mike-plummer mike-plummer changed the title Support "Queued" latest run status feat: Support "Queued" latest run status Jun 23, 2022
@cypress
Copy link

cypress bot commented Jun 23, 2022



Test summary

37681 0 456 0Flakiness 8


Run details

Project cypress
Status Passed
Commit 9aa07f7
Started Jun 23, 2022 11:11 PM
Ended Jun 23, 2022 11:29 PM
Duration 17:21 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs request + response headers
3 ... > logs Method, Status, URL, and XHR
4 ... > logs response
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@pstakoun pstakoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review: ✅

This. Is. Awesome.

@mike-plummer mike-plummer merged commit 44641ba into muaz/CLOUD-577-spec-list-display-latest-runs Jun 24, 2022
@mike-plummer mike-plummer deleted the mikep/CLOUD-577-queued-status branch June 24, 2022 14:26
tgriesser added a commit that referenced this pull request Jun 24, 2022
…esser/CLOUD-577-spec-list-display-latest-runs-batching

* muaz/CLOUD-577-spec-list-display-latest-runs:
  fix: Update "Request Access" button state after requesting access (ACI) (#22499)
  feat: Support "Queued" latest run status (#22497)
  fix: remove ctx.cloud.reset in tests, handle infinite loop in stale results (#22483)
  chore: add reporter webpack to gulp watch script (#22386)
  fix: Increase timeout for npm-webpack-dev-server tests (#22489)
  fix: Time out unmatched prerequests in proxy to avoid leaking memory (#22462)
  fix: Sort results in findCrossOriginLogs test helper to deterministic (#22481)
  fix: memory leak caused by storing base64 encoded files recieved by CDP `Network.requestWillBeSent` (#22460)
  fix: Improve cross-origin cookie handling (#22320)
  feat: Add button to clear value from search fields (#22202)
  chore: Add test to verify settings panels are collapsed by default (#22382)
  fix: process_profiler follow up work for v10 (#22363)
  chore: Update Chrome (stable) to 103.0.5060.53 (#22441)
  refactor: use design system windicss config (#21503)
  chore: update readme logo (#22433)
  chore: Update Chrome (beta) to 103.0.5060.53 (#22351)
  chore: updating version (#22432)
  Trigger Build
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2022

Released in 10.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants