Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update "Request Access" button state after requesting access (ACI) #22499

Conversation

mike-plummer
Copy link
Contributor

  • Fix state tracking so that button properly updates after requesting access
  • Refactor improper cross-component GQL doc use

User facing changelog

Additional details

Implementation adapted from RunsErrorRenderer.vue

Steps to test

  1. Open cypress app and log into dashboard
  2. Open a project that is cloud-connected but that you do not have access to
  3. Mouse over "latest runs" header, observe the "Request Access" button
  4. Click button, observe button updates to "Request Sent"
  5. Close and reopen tooltip, observe button still reports "Request Sent"

How has the user experience changed?

Screen.Recording.2022-06-23.at.7.08.10.PM.mov

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 24, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 24, 2022



Test summary

37679 2 456 0Flakiness 5


Run details

Project cypress
Status Failed
Commit 650d6dd
Started Jun 24, 2022 12:07 AM
Ended Jun 24, 2022 12:25 AM
Duration 18:36 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-electron (Linux, Electron )
net_stubbing.cy.ts Failed
1 ... > when body contains unicode
Run group: 5x-driver-firefox-experimentalSessionAndOrigin (Linux, Firefox )
actions/click.cy.js Failed
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth

Flakiness

commands/xhr.cy.js Flakiness
1 ... > logs response
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
2 ... > intercept log has consoleProps with intercept info
3 ... > intercept log has consoleProps with intercept info
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine - I'll give the entire thing a thorough test when we do the final review of the ACI feature. Nice job grokking the GraphQL stack so quickly.

@mike-plummer mike-plummer merged commit 0390470 into muaz/CLOUD-577-spec-list-display-latest-runs Jun 24, 2022
@mike-plummer mike-plummer deleted the mikep/CLOUD-577-request-access-btn branch June 24, 2022 14:27
tgriesser added a commit that referenced this pull request Jun 24, 2022
…esser/CLOUD-577-spec-list-display-latest-runs-batching

* muaz/CLOUD-577-spec-list-display-latest-runs:
  fix: Update "Request Access" button state after requesting access (ACI) (#22499)
  feat: Support "Queued" latest run status (#22497)
  fix: remove ctx.cloud.reset in tests, handle infinite loop in stale results (#22483)
  chore: add reporter webpack to gulp watch script (#22386)
  fix: Increase timeout for npm-webpack-dev-server tests (#22489)
  fix: Time out unmatched prerequests in proxy to avoid leaking memory (#22462)
  fix: Sort results in findCrossOriginLogs test helper to deterministic (#22481)
  fix: memory leak caused by storing base64 encoded files recieved by CDP `Network.requestWillBeSent` (#22460)
  fix: Improve cross-origin cookie handling (#22320)
  feat: Add button to clear value from search fields (#22202)
  chore: Add test to verify settings panels are collapsed by default (#22382)
  fix: process_profiler follow up work for v10 (#22363)
  chore: Update Chrome (stable) to 103.0.5060.53 (#22441)
  refactor: use design system windicss config (#21503)
  chore: update readme logo (#22433)
  chore: Update Chrome (beta) to 103.0.5060.53 (#22351)
  chore: updating version (#22432)
  Trigger Build
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2022

Released in 10.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants