Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testing Type switcher to Specs Explorer #26448

Closed
baus opened this issue Apr 6, 2023 · 5 comments · Fixed by #26894
Closed

Add Testing Type switcher to Specs Explorer #26448

baus opened this issue Apr 6, 2023 · 5 comments · Fixed by #26894
Assignees

Comments

@baus
Copy link

baus commented Apr 6, 2023

Screenshot 2023-05-23 at 10 43 28 AM

Screenshot 2023-05-23 at 10 43 36 AM

Screenshot 2023-05-23 at 10 53 28 AM

At the top of the specs list, there will be two buttons, one for e2e and one for component testing. Each tab will have the following features:

  • Icon for test testing type (always shown)
  • Testing type label text
    • E2E Specs
    • Component Specs
  • A question mark icon that is shown when a testing type is unconfigured.
  • Active/inactive states

When both testing types are configured
Buttons act as a switcher to put Cypress into the other testing mode.
There are no new side effects of this, the transition happens exactly as it does today when a user switches via the top-left button in the side nav - the browser closes, launchpad displays a spinner, and then the browser re-opens in the new testing type.

When one testing type is not configured
The button for the unconfigured type contains a question mark, and clicking it displays a promo in-place in the specs list page which gives a summary of the testing type and invites users to set it up.
This has a side effect: it records a "campaign viewed" event through the Cloud's /anon-collect endpoint with the following values

  • Component testing:
    campaign: Specs Switcher CT
    medium: Not set up
    if a "CT eligible" framework and bundler are detected:
    payload: { framework: {framework}, bundler: {bundler} }
    (see ComponentTestingBannerAvailable.vue for example)
  • End-to-End testing
    campaign: Specs Switcher E2E
    medium: Not set up
    payload: { framework: {framework}, bundler: {bundler} }

The implementation of the Promo elements for each unconfigured state are covered under tickets #26837 and #26836. This ticket should handle creation of the switch, switching when target type is configured, and replacing Specs List content with a placeholder when not configured.

@baus
Copy link
Author

baus commented Apr 6, 2023

@lmiller1990
Copy link
Contributor

Note: there is some product work to come from @marktnoonan - I'd recommend waiting for that before estimating this.

@mike-plummer mike-plummer changed the title Make switching testing types more discoverable Add Testing Type switcher to Specs Explorer May 23, 2023
This was referenced May 23, 2023
@mike-plummer
Copy link
Contributor

Please add your planning poker estimate with Zenhub @dkasper-was-taken

@mike-plummer
Copy link
Contributor

Please add your planning poker estimate with Zenhub @astone123

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2023

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants