feat(component-testing): changes to the driver and reporter preparing for runner-ct #14434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runScript can now use promises instead of files. Thi test this new behavior
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
I did not find where the tests for [EDIT] nevermind I found the integration tests |
JessicaSachs
reviewed
Jan 6, 2021
packages/reporter/cypress/integration/unit/runnables_store_spec.ts
Outdated
Show resolved
Hide resolved
packages/driver/cypress/integration/cypress/script_utils_spec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
lmiller1990
reviewed
Jan 6, 2021
packages/driver/cypress/integration/cypress/script_utils_spec.js
Outdated
Show resolved
Hide resolved
lmiller1990
previously approved these changes
Jan 7, 2021
kuceb
reviewed
Jan 7, 2021
dmtrKovalenko
previously approved these changes
Jan 7, 2021
elevatebart
dismissed stale reviews from dmtrKovalenko and lmiller1990
via
b4e150a
|
Except for the percy snapshot that was added, all tests seems to be passing and the coverage does not seem diminished. |
lmiller1990
approved these changes
Jan 7, 2021
brian-mann
approved these changes
Jan 8, 2021
brian-mann
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporter and Driver packages
changes necessary for runner-ct
driver
Since the specs are loaded using a dev-server, we need to be able to delegate the loading to webpack/vite/parcel.
To that effect, we allow to initialize
runScriptsindriver/src/cypress/scripts_utils.jsto accept promises instead of file paths.Also, there is a little fix on the script utils tests (it was not testing that eval was called).
reporter
To allow running of multiple specs files at once we need to add a history of runnables in the runnables store.
The runner-ct will allow to start & watch multiple specs at once so we will need to be able to run those through the reporter.
Accounting for this multi-spec mode means also having this
runModeas a prop for the reporter component.closes CT-201