fix: addressing style regressions in the CT runner #15542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
agg23
previously approved these changes
Mar 17, 2021
JessicaSachs
force-pushed
the
fix/broken-css
branch
from
808bceb
to
c65d254
Compare
agg23
suggested changes
Mar 17, 2021
| @@ -255,8 +258,11 @@ const App: React.FC<AppProps> = observer( | |||
| maxSize={hideIfScreenshotting(() => state.isSpecsListOpen ? 600 : 0)} | |||
| defaultSize={hideIfScreenshotting(() => state.isSpecsListOpen ? state.specListWidth : 0)} | |||
| onDragFinished={persistWidth('ctSpecListWidth')} | |||
| className="primary" | |||
| className={cs('primary', { 'isSpecsListClosed': !state.isSpecsListOpen })} | |||
| // @ts-expect-error split-pane ref types are weak so we are using our custom type for ref | |||
There was a problem hiding this comment.
This comment needs to be moved or removed (and it will throw a TS error right now)
There was a problem hiding this comment.
Yes, but out of scope for this PR
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
agg23
approved these changes
Mar 17, 2021
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
Closed
elevatebart
added a commit
that referenced
this pull request
Mar 18, 2021
Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com> Co-authored-by: Barthélémy Ledoux <bart@cypress.io> Co-authored-by: ElevateBart <ledouxb@gmail.com>
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
This addresses the style changes when merging #15513
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?