Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open config file in user's editor #19276

Merged
merged 10 commits into from
Dec 7, 2021

Conversation

estrada9166
Copy link
Member

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 6, 2021



Test summary

4246 0 47 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 981476e
Started Dec 7, 2021 10:23 PM
Ended Dec 7, 2021 10:34 PM
Duration 11:19 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 marked this pull request as ready for review December 7, 2021 03:07
lmiller1990
lmiller1990 previously approved these changes Dec 7, 2021
@lmiller1990 lmiller1990 merged commit 5b409eb into 10.0-release Dec 7, 2021
@lmiller1990 lmiller1990 deleted the alejandro/feat/open-config-idle branch December 7, 2021 22:30
tgriesser added a commit that referenced this pull request Dec 9, 2021
* 10.0-release: (53 commits)
  refactor: makeLegacyContext -> getCtx (#19308)
  fix: various Nav Bar fixes (#19283)
  build: add patch package as a dev dependency for fe-shared
  chore: hoist is - fun with cached dependencies
  build: hoist is hard
  build: better hoisting strategy
  chore: remove unused testing preferences (#19301)
  fix: remove windows and mac workflow from branch
  fix: show script errors when spec file fails to process (#19298)
  revert: remove change about node version 17
  feat: open config file in user's editor (#19276)
  feat(unify): scale the AUT (#19297)
  build: remove testing of desktop-gui assets
  build: run window & mac CI in this branch
  build: more fixes
  build: remove toycode mdi from launchpad
  rename patch because of dev dep
  build: fix  merge issue in packages generation
  chore: update sass for windows compatibility
  fix: Do not crash when a ill formed URL request is proxied (#19274)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants