Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update @cypress/request to 3.0.1 #29864

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jul 16, 2024

Additional details

Due to

"@cypress/request": "^3.0.0",
existing Cypress installations could continue to use the deprecated qs@6.10.5 version instead of reverting to the supported qs@6.10.4 version.

The dependency was corrected already in @cypress/request@3.0.1, however so far it was not enforced in Cypress.

Steps to test

npm install yarn@latest -g
git clone https://github.com/cypress-io/github-action
git checkout cdb79e380ec33758c5c7436e67a84243e1302c90
cd github-action/examples/yarn-classic
git clean -xfd
yarn install --frozen-lockfile
yarn add cypress@latest -D
yarn list --pattern qs

Ensure that qs@6.10.4 is installed (not qs@6.10.5).

How has the user experience changed?

User projects should no longer contain the deprecated qs@6.10.5 in their configuration.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@jennifer-shehane
Copy link
Member

May be related to this just merging: #29830 Checking up on this.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Thanks for fixing!

@cacieprins cacieprins self-requested a review July 16, 2024 19:35
@jennifer-shehane
Copy link
Member

Yay finally!

@jennifer-shehane jennifer-shehane merged commit 767ddf8 into cypress-io:develop Jul 25, 2024
68 checks passed
@MikeMcC399 MikeMcC399 deleted the issue-29863-update-cypress-request-dep branch July 25, 2024 15:09
@MikeMcC399
Copy link
Contributor Author

Verification

Ubuntu 22.04.4 LTS, Node.js 20.16.0 LTS

Steps

npm install yarn@latest -g
git clone https://github.com/cypress-io/github-action
git checkout cdb79e380ec33758c5c7436e67a84243e1302c90
cd github-action/examples/yarn-classic
git clean -xfd
yarn install --frozen-lockfile
yarn list --pattern cypress
yarn list --pattern qs
yarn add https://cdn.cypress.io/beta/npm/13.13.2/linux-x64/develop-767ddf8584c0297f84ca868ae580e89e856ed9d1/cypress.tgz -D # from PR 29864

Logs

qs was correctly downgraded to qs@6.10.4 (the non-deprecated version)

$ yarn list --pattern cypress
yarn list v1.22.22
├─ @cypress/request@3.0.0
├─ @cypress/xvfb@1.2.4
└─ cypress@13.1.0
Done in 0.15s.
$ yarn list --pattern qs
yarn list v1.22.22
└─ qs@6.10.5
Done in 0.16s.
$ yarn add https://cdn.cypress.io/beta/npm/13.13.2/linux-x64/develop-767ddf8584c0297f84ca868ae580e89e856ed9d1/cypress.tgz -D # from PR 29864
yarn add v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
└─ cypress@13.13.2
info All dependencies
├─ cypress@13.13.2
└─ qs@6.10.4
Done in 71.69s.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 31, 2024

Released in 13.13.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated qs@6.10.5 dependency of @cypress/request not reverted to qs@6.10.4
4 participants