-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: update @cypress/request to 3.0.1 #29864
Merged
jennifer-shehane
merged 7 commits into
cypress-io:develop
from
MikeMcC399:issue-29863-update-cypress-request-dep
Jul 25, 2024
Merged
dependency: update @cypress/request to 3.0.1 #29864
jennifer-shehane
merged 7 commits into
cypress-io:develop
from
MikeMcC399:issue-29863-update-cypress-request-dep
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be related to this just merging: #29830 Checking up on this. |
jennifer-shehane
approved these changes
Jul 16, 2024
Thanks for fixing! |
cacieprins
approved these changes
Jul 23, 2024
Yay finally! |
VerificationUbuntu Stepsnpm install yarn@latest -g
git clone https://github.com/cypress-io/github-action
git checkout cdb79e380ec33758c5c7436e67a84243e1302c90
cd github-action/examples/yarn-classic
git clean -xfd
yarn install --frozen-lockfile
yarn list --pattern cypress
yarn list --pattern qs
yarn add https://cdn.cypress.io/beta/npm/13.13.2/linux-x64/develop-767ddf8584c0297f84ca868ae580e89e856ed9d1/cypress.tgz -D # from PR 29864 Logs
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qs@6.10.5
dependency of@cypress/request
not reverted toqs@6.10.4
#29863Additional details
Due to
cypress/cli/package.json
Line 23 in cbbc8ee
The dependency was corrected already in @cypress/request@3.0.1, however so far it was not enforced in Cypress.
Steps to test
npm install yarn@latest -g git clone https://github.com/cypress-io/github-action git checkout cdb79e380ec33758c5c7436e67a84243e1302c90 cd github-action/examples/yarn-classic git clean -xfd yarn install --frozen-lockfile yarn add cypress@latest -D yarn list --pattern qs
Ensure that qs@6.10.4 is installed (not qs@6.10.5).
How has the user experience changed?
User projects should no longer contain the deprecated qs@6.10.5 in their configuration.
PR Tasks
cypress-documentation
?type definitions
?