Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated qs@6.10.5 dependency of @cypress/request not reverted to qs@6.10.4 #29863

Closed
MikeMcC399 opened this issue Jul 16, 2024 · 3 comments · Fixed by #29864
Closed

deprecated qs@6.10.5 dependency of @cypress/request not reverted to qs@6.10.4 #29863

MikeMcC399 opened this issue Jul 16, 2024 · 3 comments · Fixed by #29864
Labels
process: dependencies Related to internal dependencies

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jul 16, 2024

Current behavior

If a yarn.lock was generated before the release of @cypress/request@3.0.1 on Sept 6, 2023 it is possible for an installation of Cypress to continue to hold the deprecated qs@6.10.5 version instead of reverting to the supported qs@6.10.4 version.

Desired behavior

Any installation of cypress@13.0.0 or later should cause the non-deprecated version qs@6.10.4, as a dependency of @cypress/request, to be installed. This should be independent of the previous history of installation according to any existing node_modules directory or package manager lock file.

It should not be necessary to uninstall Cypress and reinstall it in order to reach a supported configuration.

Test code to reproduce

npm install yarn@latest -g
git clone https://github.com/cypress-io/github-action
git checkout cdb79e380ec33758c5c7436e67a84243e1302c90
cd github-action/examples/yarn-classic
git clean -xfd
yarn install --frozen-lockfile
yarn add cypress@latest -D
yarn list --pattern qs

Cypress Version

13.13.0

Node version

v20.15.1 LTS

Operating System

Ubuntu 22.04.4 LTS

Debug Logs

$ yarn list --pattern qs
yarn list v1.22.22
└─ qs@6.10.5

$ yarn list --pattern cypress
yarn list v1.22.22
├─ @cypress/request@3.0.0
├─ @cypress/xvfb@1.2.4
└─ cypress@13.13.0

Other

Suggestion

In https://github.com/cypress-io/cypress/blob/develop/cli/package.json

"@cypress/request": "^3.0.0",

bump to "@cypress/request": "^3.0.1"

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane jennifer-shehane added the process: dependencies Related to internal dependencies label Jul 16, 2024
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 31, 2024

Released in 13.13.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
process: dependencies Related to internal dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants