-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron upgrade #5849
Merged
Merged
Electron upgrade #5849
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1cae916
electron@7.x
flotwig db2d521
node12.8.1-chrome78-ff70
flotwig 57fe764
Revert "node12.8.1-chrome78-ff70" for now
flotwig 2bef520
update sendCommand to log on all sendcommands
flotwig 27bdd97
promisification in 6.x
flotwig 8097a81
Revert "Revert "node12.8.1-chrome78-ff70" for now"
flotwig 527b203
Merge branch 'decaf-server-lib-automation' into electron-upgrade
flotwig 0282b98
fix sendcommand
flotwig 12e5e48
fix cdp in electron
flotwig 9710805
fix desktop-gui test
flotwig 176b18c
skip tests that will be fixed by #4973
flotwig 3d996ff
bump MAX_ALLOWED_FILE_SIZE :/
flotwig dc577e9
update electron browser spec
flotwig 50320d8
make new dialog code null-proof
flotwig 226fd6e
add failing e2e test for issue 5475
brian-mann 323bae5
bump electron packager
brian-mann 0850372
add e2e snapshot
brian-mann bfc9005
Merge branch 'develop' into electron-upgrade
flotwig 0bf8621
update deprecated electron getters/setters
flotwig 77b362e
build and test on Mac
bahmutov 45d3bd5
Merge remote-tracking branch 'origin/develop' into electron-upgrade
flotwig 0044db9
move macbuildfilters to top
flotwig e6d64b9
7.1.3
flotwig 15ca743
Merge branch 'develop' into electron-upgrade
flotwig decb35b
electron@7.1.4
flotwig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
exports['e2e issue 5475 history pushState hangs / fails when remote debugging port cannot be connected to'] = ` | ||
|
||
==================================================================================================== | ||
|
||
(Run Starting) | ||
|
||
┌────────────────────────────────────────────────────────────────────────────────────────────────┐ | ||
│ Cypress: 1.2.3 │ | ||
│ Browser: FooBrowser 88 │ | ||
│ Specs: 2 found (issue_5475_spec_1.js, issue_5475_spec_2.js) │ | ||
│ Searched: cypress/integration/issue_5475* │ | ||
└────────────────────────────────────────────────────────────────────────────────────────────────┘ | ||
|
||
|
||
──────────────────────────────────────────────────────────────────────────────────────────────────── | ||
|
||
Running: issue_5475_spec_1.js (1 of 2) | ||
|
||
|
||
issue #5475 | ||
✓ hangs on next spec after modifying history.pushState | ||
|
||
|
||
1 passing | ||
|
||
|
||
(Results) | ||
|
||
┌────────────────────────────────────────────────────────────────────────────────────────────────┐ | ||
│ Tests: 1 │ | ||
│ Passing: 1 │ | ||
│ Failing: 0 │ | ||
│ Pending: 0 │ | ||
│ Skipped: 0 │ | ||
│ Screenshots: 0 │ | ||
│ Video: true │ | ||
│ Duration: X seconds │ | ||
│ Spec Ran: issue_5475_spec_1.js │ | ||
└────────────────────────────────────────────────────────────────────────────────────────────────┘ | ||
|
||
|
||
(Video) | ||
|
||
- Started processing: Compressing to 32 CRF | ||
- Finished processing: /XXX/XXX/XXX/cypress/videos/issue_5475_spec_1.js.mp4 (X second) | ||
|
||
|
||
──────────────────────────────────────────────────────────────────────────────────────────────────── | ||
|
||
Running: issue_5475_spec_2.js (2 of 2) | ||
|
||
|
||
issue #5475 | ||
1) hangs on next spec after modifying history.pushState | ||
|
||
|
||
0 passing | ||
1 failing | ||
|
||
1) issue #5475 hangs on next spec after modifying history.pushState: | ||
Error: foo | ||
[stack trace lines] | ||
|
||
|
||
|
||
|
||
(Results) | ||
|
||
┌────────────────────────────────────────────────────────────────────────────────────────────────┐ | ||
│ Tests: 1 │ | ||
│ Passing: 0 │ | ||
│ Failing: 1 │ | ||
│ Pending: 0 │ | ||
│ Skipped: 0 │ | ||
│ Screenshots: 2 │ | ||
│ Video: true │ | ||
│ Duration: X seconds │ | ||
│ Spec Ran: issue_5475_spec_2.js │ | ||
└────────────────────────────────────────────────────────────────────────────────────────────────┘ | ||
|
||
|
||
(Screenshots) | ||
|
||
- /XXX/XXX/XXX/cypress/screenshots/issue_5475_spec_2.js/hangs.png (1000x660) | ||
- /XXX/XXX/XXX/cypress/screenshots/issue_5475_spec_2.js/issue #5475 -- hangs on ne (1280x720) | ||
xt spec after modifying history.pushState (failed).png | ||
|
||
|
||
(Video) | ||
|
||
- Started processing: Compressing to 32 CRF | ||
- Finished processing: /XXX/XXX/XXX/cypress/videos/issue_5475_spec_2.js.mp4 (X second) | ||
|
||
|
||
==================================================================================================== | ||
|
||
(Run Finished) | ||
|
||
|
||
Spec Tests Passing Failing Pending Skipped | ||
┌────────────────────────────────────────────────────────────────────────────────────────────────┐ | ||
│ ✔ issue_5475_spec_1.js XX:XX 1 1 - - - │ | ||
├────────────────────────────────────────────────────────────────────────────────────────────────┤ | ||
│ ✖ issue_5475_spec_2.js XX:XX 1 - 1 - - │ | ||
└────────────────────────────────────────────────────────────────────────────────────────────────┘ | ||
✖ 1 of 2 failed (50%) XX:XX 2 1 1 - - | ||
|
||
|
||
` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR updating the Node version? Aren't we using 12.0.0, don't we want to test against that?
Also, if this is a convenience thing - probably highlights why our docker images combinations are problematic for our own users. :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the bundled Node version to 12.8.1 (Electron 5 -> 7). The
node
version we use in CI needs to match this, since the unit + integrations tests (of Electron code) all run innode
in CI, notelectron
. We could useelectron-mocha
to eliminate this requirement, but currently that's the way it is.