fix: Add support for template literals to require-data-selectors rule

fix: require data selectors support template literal
cypress-io · Feb 18, 2020 · 958549f · 958549f
2 parents 61af626 + 550f377
commit 958549f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/rules/require-data-selectors.js b/lib/rules/require-data-selectors.js
@@ -39,7 +39,8 @@ function isCallingCyGet (node) {
 
 function isDataArgument (node) {
   return node.arguments.length > 0 &&
-  node.arguments[0].type === 'Literal' &&
-  String(node.arguments[0].value).startsWith('[data-')
-
+    (
+      (node.arguments[0].type === 'Literal' && String(node.arguments[0].value).startsWith('[data-')) ||
+      (node.arguments[0].type === 'TemplateLiteral' && String(node.arguments[0].quasis[0].value.cooked).startsWith('[data-'))
+    )
 }
diff --git a/tests/lib/rules/require-data-selectors.js b/tests/lib/rules/require-data-selectors.js
@@ -15,6 +15,7 @@ ruleTester.run('require-data-selectors', rule, {
     { code: 'cy.clock(5000)', parserOptions },
     { code: 'cy.scrollTo(0, 10)', parserOptions },
     { code: 'cy.tick(500)', parserOptions },
+    { code: 'cy.get(\`[data-cy=${1}]\`)', parserOptions },
   ],
 
   invalid: [
@@ -23,5 +24,6 @@ ruleTester.run('require-data-selectors', rule, {
     { code: 'cy.get(".btn-large").click()', parserOptions, errors },
     { code: 'cy.get(".btn-.large").click()', parserOptions, errors },
     { code: 'cy.get(".a")', parserOptions, errors },
+    { code: 'cy.get(\`[daedta-cy=${1}]\`)', parserOptions, errors },
   ],
 })