Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let passage titles appear in Outline #1

Closed
MxAshUp opened this issue Aug 17, 2020 · 6 comments
Closed

Let passage titles appear in Outline #1

MxAshUp opened this issue Aug 17, 2020 · 6 comments

Comments

@MxAshUp
Copy link

MxAshUp commented Aug 17, 2020

This is a duplication of an issue from the extension I've been managing over here: MxAshUp/vscode-twee2-syntax#8

Considering the amount of effort already put into this extension, it may be simpler to implement this feature here instead!

For reference, the outline is located beneath the file explorer and look like this currently with twee extension enabled:
Screenshot from 2020-08-17 14-00-09

This functionality has already been implemented with the passage list feature. Would there be any benefit to having this in the outline instead, or in addition to?

As far as I understand the outline pane, symbols would need to be described in the language server for passage titles, and these would be recognized for the outline hierarchy.

@cyrusfirheir
Copy link
Owner

My original idea with the extra view container was that it'd have more tabs. Only have passages for now, and when new ideas pop up, I'll add them in.

But adding them to the outline section doesn't sound like a bad idea. I'll look into it.

@cyrusfirheir
Copy link
Owner

Okay, if I'm understanding this correctly, the Outline view lists all the symbols in the active document. Could be useful... But I'm more inclined towards having a simple filter/sort button in the existing passage list which pushes the passages in the current file to the top.

And if this is about having to navigate to another view container, you can always drag the passage list out and dock it under the file explorer. Pushing stuff to the Outline view seems like needless extra work.

Unless there are some other benefits I'm not seeing, of course.

@MxAshUp
Copy link
Author

MxAshUp commented Aug 19, 2020

I think you're probably right! The original user who brought this up was @wkc1986. I pointed them here to your extension, which may solve their problem.

But yeah it might be needless work if nobody needs it, and it sounds like the passage list you built does a lot more than list symbols.

@wkc1986
Copy link

wkc1986 commented Aug 25, 2020

Thanks for this great extension which I didn't know at first but Dustin directed me to. I think the current passage list is great, especially as it scans all Twee files in the working directory--it would be great if there were a way to filter for passages from the current file, or with a tag.

@cyrusfirheir
Copy link
Owner

Yes, sorting, filtering, grouping, all of that good stuff is planned.

@cyrusfirheir
Copy link
Owner

@wkc1986 commented on Aug 26

Thanks for this great extension which I didn't know at first but Dustin directed me to. I think the current passage list is great, especially as it scans all Twee files in the working directory--it would be great if there were a way to filter for passages from the current file, or with a tag.

v0.5.0 adds grouping by file and tags. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants