audit callbacks from mboxlist_findall() and friends for handling of data->mbname #2472
Labels
3.0
affects 3.0
3.1
affects 3.1 dev releases
help wanted
would like input from non-regular contributors
The
mboxlist_findall()
and related APIs will call the callback under a number of different situations:Depending on exactly how the pattern was matched, the callback may be called with its
struct findall_data *data
argument in various states:We keep getting issues where sections of code are naively not expecting partial matches, and then crashing because they depend on something being in the data struct which isn't.
So perhaps instead of fixing these piecemeal as they come up, we should actually audit all the callers of the mboxlist_findall() APIs to ensure their callback functions deal with partial matches sanely (in most cases, probably just by explicitly ignoring them, rather than crashing!).
The text was updated successfully, but these errors were encountered: