-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: recent sphinx-build warns about 'rfc' role being overridden #7
Labels
3.0
affects 3.0
Comments
I'm running sphinx 1.3.6 I yanked the rfc entry in conf.py and everything built beautifully. |
I can't seem to assign it to me or mark it fixed. commit 3a004c1 |
Pull request merged. Closing issue. |
This was referenced Dec 13, 2016
Closed
Closed
This was referenced Dec 13, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building our docs with sphinx-build 1.4.5:
Our
rfc
is defined in docsrc/conf.py:The thing is, sphinx already has such a thing built in. And looks like it has had it built in pretty much forever: sphinx-doc/sphinx@d60ca8d
The difference with the newer version of sphinx-build appears to be that it now warns about us overriding built-in functionality, instead of just quietly doing it. We should be able to shut up this warning just by no longer defining our own rfc role. The built-in one does basically the same thing anyway (except that it uses a https link to the same destination -- good!).
We need to support at least back to version 1.3.6, because that's what the website rebuild uses, but I can't easily test that version now that I've upgraded.
The text was updated successfully, but these errors were encountered: