Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip --no-name args to compression output #83

Closed
gwaybio opened this issue Jun 1, 2020 · 2 comments · Fixed by #119
Closed

Add gzip --no-name args to compression output #83

gwaybio opened this issue Jun 1, 2020 · 2 comments · Fixed by #119

Comments

@gwaybio
Copy link
Member

gwaybio commented Jun 1, 2020

Once pandas 1.1 is released, explore adding --no-name arg in pycytominer.cyto_utils.output()

See pandas-dev/pandas#33398

@gwaybio
Copy link
Member Author

gwaybio commented Dec 14, 2020

Pandas version 1.2 will include the actual change that will solve this issue https://github.com/pandas-dev/pandas/pull/35645/files#diff-dfaa007d8bd37e94f4cf560555634a58ad8158360d79f0d30b24859d89504f57R298

The switch will indeed be in pycytominer.cyto_utils.output() and will require us to set a gzip kwarg:

compression = {'method': 'gzip', 'mtime': 1}

a pandas 1.2 release candidate is available at https://github.com/pandas-dev/pandas/releases

@gwaybio
Copy link
Member Author

gwaybio commented Jan 5, 2021

pandas 1.2 is released! This includes the fix that will solve this issue and help with large gzip diffs https://pandas.pydata.org/docs/whatsnew/v1.2.0.html#i-o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant