Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tippy example in README.md #64

Closed
wants to merge 1 commit into from

Conversation

thehappydinoa
Copy link

No description provided.

```html
<script src="https://unpkg.com/tippy.js@6/dist/tippy-bundle.umd.min.js"></script>
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could suggesting specific CDN links make novice users expect that those are the only links that would work (only those specific versions etc.)?

Would the demo HTML files be a better place to comment on / document these links?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that could definitely help, maybe we could just link to the demo file rather than the demo here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. There are demo links at the top, but maybe they could be also linked in the relevant sections to make them more noticeable.

README.md Show resolved Hide resolved
@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically marked as stale, because it has not had activity within the past 30 days. It will be closed if no further activity occurs within the next 30 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2021
@stale stale bot closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants