Adding background-image-smoothing property #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkfranz
reviewed
Dec 7, 2020
.size-snapshot.json
Outdated
| @@ -1,39 +1,39 @@ | |||
| { | |||
| "build/cytoscape.umd.js": { | |||
There was a problem hiding this comment.
Could you reset this file? It's only for releases. Given the confusion it creates, it might be even better to not generate this file at all any more.
documentation/md/style.md
Outdated
| @@ -297,6 +297,7 @@ A background image may be applied to a node's body. The following properties su | |||
| * The [`cytoscape-sbgn-stylesheet`](https://github.com/PathwayCommons/cytoscape-sbgn-stylesheet) package serves as a good example for the use of SVG images in a stylesheet. That stylesheet [creates decorations](https://pathwaycommons.github.io/cytoscape-sbgn-stylesheet/) on nodes in line with the [SBGN standard](https://sbgn.github.io). | |||
| * **`background-image-crossorigin`**: All images are loaded with a [`crossorigin`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-crossorigin) attribute which may be `anonymous` or `use-credentials`. The default is set to `anonymous`. | |||
| * **`background-image-opacity`** : The opacity of the background image. | |||
| * **`background-image-smoothing`** : Determines whether background image is smoothed (`yes`, default) or not (`no`). This feature isn't well supported across browsers. | |||
There was a problem hiding this comment.
Could this be made a bit more explicit that it's a only a hint? The browser may or may not respect the value set for this property.
src/style/properties.js
Outdated
| @@ -48,6 +48,7 @@ const styfn = {}; | |||
| bgFit: { enums: [ 'none', 'contain', 'cover' ], multiple: true }, | |||
| bgCrossOrigin: { enums: [ 'anonymous', 'use-credentials' ], multiple: true }, | |||
| bgClip: { enums: [ 'none', 'node' ], multiple: true }, | |||
| bgSmooth: { enums: [ 'yes', 'no' ], multiple: true }, | |||
There was a problem hiding this comment.
Should probably be named something like bools so that it could be used for other props in future. See bool prop that follows
Reset .size-snapshot.json Clarified the documentation of the property Renamed the property type to make it reusable Formatted the code
|
Merged. Thanks for the PR |
|
Thanks for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
background-image-smoothingproperty, which can be either set toyes(default) orno.#2775