Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destiny2_GetProfile needs to send an empty list if no components are given #36

Closed
PatrickMatthiesen opened this issue Jul 11, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@PatrickMatthiesen
Copy link

the server returns 500 if the components part is not in the URL in the header

@Cytraen
Copy link
Owner

Cytraen commented Jul 19, 2022

Is there something wrong with giving an empty list manually? The OpenAPI spec doesn't say whether a query param is required or not, and I would prefer to not add a special case for individual endpoints.

The API documentation states You must request at least one component to receive results anyway so I don't see a reason to change this.

@PatrickMatthiesen
Copy link
Author

PatrickMatthiesen commented Jul 19, 2022

I’m kinda new to using open source libraries, but I just didn’t see it in the code documentation (might just have missed it), but bungie does say it in their doc. So was mostly for convenience when using your library.

@Cytraen
Copy link
Owner

Cytraen commented Jul 23, 2022

The documentation in BungieSharper is a direct copy-paste of the Bungie documentation. The bit I quoted is under the documentation for the components parameter.

@Cytraen Cytraen closed this as completed Jul 23, 2022
@Cytraen Cytraen added the wontfix This will not be worked on label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants