Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration expiration #112

Closed
tpazderka opened this issue Aug 20, 2015 · 2 comments
Closed

Registration expiration #112

tpazderka opened this issue Aug 20, 2015 · 2 comments

Comments

@tpazderka
Copy link
Collaborator

When a new registration is returned from the registration_endpoint, it contains a non-zero value in client_secret_expires_at. This indicates that after this time, the secret should not be valid but it is not true. The validity of secret is not checked anywhere during the processing of the requests.
According to specifications, this should return 0 in client_secret_expires_at.

But I think it would be more useful to add the checking of the client_secret validity to the code as well as a configuration option for the validity itself.

@rohe
Copy link
Collaborator

rohe commented May 11, 2016

I've added a function for validating a client registration which basically is checking if the client_secret_expired_at time has passed or not.

@tpazderka
Copy link
Collaborator Author

Resolved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants