Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes related to chunks and MIDASDB #66

Merged
merged 15 commits into from
Oct 28, 2021
Merged

Conversation

zhaoc1
Copy link
Contributor

@zhaoc1 zhaoc1 commented Oct 28, 2021

  1. Since the design of the chunks depends only on (1) the representative genomes / the pan-genome (2) chunk size. We decide to cache the chunk's design. Besides, in addition to carry the chunks design in a global variable, which can be quite heavy for large number of species of interest, we decide to only carry the cache path of the chunks for given species.
  2. Add major/minor allele compute to midas_run_snps, and the user can choose to report extra columns by --advanced.
  3. Clean up commands to build midas db while building it for GTDB.
  4. Add midasdb_name and get_midasdb_layout to accesss to any path that is related with midas database.
  5. Update unit testing codes, as well as building toy db locally.
  6. Passed unit test.

@zhaoc1 zhaoc1 merged commit 0309ecb into master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant