Crash - no available platforms on Xcode Server

[czechboy0]

Happens on certain instances of Xcode Server

Application Specific Information:
fatal error: Couldn't find intended platform in list of platforms: []!: file /Users/honzadvorsky/Documents/Buildasaur/Pods/XcodeServerSDK/XcodeServerSDK/API Routes/XcodeServer+Bot.swift, line 172

Originally reported by @valeriomazzeo in buildasaurs/Buildasaur#143.

---

Solution:

• instead of crashing, just generate an error describing this issue and fail the bot-creation process
• make sure Buildasaur shows this error in the UI

[cojoj]

You rather want it to return some kind of completion or simply throw?

[cojoj]

I think if we want to fail bot creation process we should stick with throw 😉 I'll try to do something with this issue today...

[czechboy0]

It's an asynchronous process so I don't think throw will work. Just
creating an error and completing should be enough.
On Thu, Oct 1, 2015 at 9:53 AM Mateusz Zając notifications@github.com
wrote:

I think if we want to fail bot creation process we should stick with throw
😉 I'll try to do something with this issue today...

—
Reply to this email directly or view it on GitHub
#114 (comment)
.

[cojoj]

private func replacePlaceholderPlatformInBot(bot: Bot, platforms: [DevicePlatform]) is the method in which the fatalErrors are called... Looks to me like it's totally synchronous. The bot creation isn't synchronous... Anyway, you suggest returning of the optional ErrorType from this method? Seems legit 😉

[czechboy0]

Oh right, I was talking about the big picture of the whole process. Makes
perfect sense here to throw, sorry. What I meant is that that error should
then be fed into the failing completion block.
On Thu, Oct 1, 2015 at 10:02 AM Mateusz Zając notifications@github.com
wrote:

private func replacePlaceholderPlatformInBot(bot: Bot, platforms:
[DevicePlatform]) is the method in which the fatalErrors are called...
Looks to me like it's totally synchronous. The bot creation isn't
synchronous... Anyway, you suggest returning of the optional ErrorType
from this method? Seems legit 😉

—
Reply to this email directly or view it on GitHub
#114 (comment)
.

[cojoj]

Communication is always an issue in my case 😜 Great that we're now on the same tracks!