Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoothScroll as a service works in .js but not in min.js #59

Open
santhotech opened this issue Feb 5, 2016 · 5 comments
Open

smoothScroll as a service works in .js but not in min.js #59

santhotech opened this issue Feb 5, 2016 · 5 comments

Comments

@santhotech
Copy link

I think the min.js file in this repo is broken. I saw an other issue complaining about scroll-to directive not working. The same case with me but with smoothScroll service in controller. If the lib/.js file is included it works, if the dist/.min.js file is included, it does not work.

@iRoachie
Copy link

iRoachie commented Feb 9, 2016

Just confirmed this. Was not working with the min. Switched to the other file and it worked right away.

@dweitz43
Copy link

I also dealt with this problem, I tried to minify the file myself and found that it works. I will submit a pull request with the newly minified file.

@dweitz43
Copy link

#60

@psegarel
Copy link

psegarel commented Jul 8, 2016

Same issue. Couldn't make it work with the min.js file, had to use the lib version

@dweitz43
Copy link

dweitz43 commented Jul 8, 2016

@psegarel check this #60 not sure if it will ever be merged but it does allow you to use the minified source correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants