Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong CFBundleIdentifier #9

Closed
Randomblock1 opened this issue Nov 9, 2020 · 2 comments
Closed

Wrong CFBundleIdentifier #9

Randomblock1 opened this issue Nov 9, 2020 · 2 comments

Comments

@Randomblock1
Copy link
Contributor

This makes the plist file generate wrong. Fixing it would fix preferences.

CocoaTop/src/res/Info.plist

Line 21 in c7ab21b

<string>com.sxx.CocoaTop</string>

@badger200
Copy link

Is this in response to my big comment on the iOS 13 commit I made moments ago about this exact issue? Or just a huge coincidence? (Bc wow that was fast)

@Randomblock1
Copy link
Contributor Author

Yep. I didn't really look too hard into what was changed, I missed this one. I think this is the only change we need to make to make it fully compatible as an upgrade.

@Randomblock1 Randomblock1 mentioned this issue Nov 10, 2020
Merged
@D0m0 D0m0 closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@D0m0 @badger200 @Randomblock1