Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Warning about missing popperjs #44

Open
Xiphoseer opened this issue Nov 2, 2020 · 3 comments
Open

Warning about missing popperjs #44

Xiphoseer opened this issue Nov 2, 2020 · 3 comments
Labels
bug dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Comments

@Xiphoseer
Copy link
Member

Xiphoseer commented Nov 2, 2020

Deployment warns us that:

bootstrap@4.5.3 requires a peer of popper.js@^1.16.1 but none is installed.
You must install peer dependencies yourself.

I think nobody uses bootstrap popovers at the moment, but this may still be a broken state of our templates and package.json

What do you think @joachimschmidt557 ?

@Xiphoseer Xiphoseer added bug javascript Pull requests that update Javascript code dependencies Pull requests that update a dependency file labels Nov 4, 2020
@joachimschmidt557
Copy link
Member

I think there is no use of popovers on the website currently. I agree that we can add popper.js to the npm dependencies. But should we include the javascript in the HTML templates if we don't use them?

@Xiphoseer
Copy link
Member Author

I think we should if we add it, so it doesn't just fail silently

@joachimschmidt557
Copy link
Member

Ok, I'll work on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants