Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DialogModal Component #784

Closed
nataliepina opened this issue Oct 5, 2022 · 7 comments
Closed

Refactor DialogModal Component #784

nataliepina opened this issue Oct 5, 2022 · 7 comments
Assignees

Comments

@nataliepina
Copy link
Collaborator

nataliepina commented Oct 5, 2022

Description

This issue is related to refactoring the DialogModal Component.

Acceptance Criteria

Refactor the component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.
Components may require updates to wrapping or related components.

Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.

How to Contribute

Please review the contributing documentation beforehand.

Steps to Contribute:

  1. Fork the repository.
  2. Clone it to your local system.
  3. Create a new branch.
  4. Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
  5. Commit your changes. When committing be sure to prefix with the appropriate conventional commit type. For example, refactor: button component.
  6. Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
  7. Fill out the pull request form and attach the "ready to review" label when complete.
@nataliepina nataliepina added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest open-source labels Oct 5, 2022
@ShivanshCharak
Copy link

hi @nataliepina i would like to contribute to this issue

@nataliepina
Copy link
Collaborator Author

@ShivanshCharak assigning it over to you, thanks.

@nataliepina
Copy link
Collaborator Author

Hey, @ShivanshCharak have you been able to make any progress here? Please let us know if you need any help.

@nataliepina
Copy link
Collaborator Author

We haven't heard from you in a bit @ShivanshCharak so I'm going to go ahead and unassign this issue so that someone else can grab it.

@nataliepina
Copy link
Collaborator Author

@davidtaing this one has opened back up if you have any interest, but no pressure.

@davidtaing
Copy link
Contributor

Thanks @nataliepina, I'll take this.

@nataliepina
Copy link
Collaborator Author

Thanks, @davidtaing 🙌🏻 If it ends up requiring updates to other modal-related components h and that becomes a lot feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants