-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DialogModal Component #784
Comments
hi @nataliepina i would like to contribute to this issue |
@ShivanshCharak assigning it over to you, thanks. |
Hey, @ShivanshCharak have you been able to make any progress here? Please let us know if you need any help. |
We haven't heard from you in a bit @ShivanshCharak so I'm going to go ahead and unassign this issue so that someone else can grab it. |
@davidtaing this one has opened back up if you have any interest, but no pressure. |
Thanks @nataliepina, I'll take this. |
Thanks, @davidtaing 🙌🏻 If it ends up requiring updates to other modal-related components h and that becomes a lot feel free to reach out. |
Description
This issue is related to refactoring the
DialogModal
Component.Acceptance Criteria
Refactor the component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.
Components may require updates to wrapping or related components.
Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.
How to Contribute
Please review the contributing documentation beforehand.
Steps to Contribute:
npm run test -- -u
and include the updated tests in your commit.refactor: button component
.The text was updated successfully, but these errors were encountered: