-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the InteractionModeEngine class to be functional #799
Comments
can you assign to me |
Yes, thanks @manojku1803. |
What is the meaning of branch formatting? |
How to do this? Please explain it... |
@manojku1803, where are you up to? |
Not know how to do this.. |
Happy to help, but you need to give me more information. Where should I start? Edit: Thinking more about this, I think I should have asked what steps have you done already. Try to create a branch as @mstruebing said below. |
@manojku1803 your branchname should be something like: i.e. in your case: Please let me know if you need more help. |
Thanks @mstruebing and @davidtaing. The branch naming is more of a suggestion but it is not required. I hope that helps @manojku1803. We've also improved the How to Contribute steps so this does not seem as much of a requirement. We appreciate your feedback. |
I think I haven't enough knowledge in it. So I can't understand the issues.. |
No worries @manojku1803 this one is more complex. I will unassign this issue from you. Please let us know if you need help with the other issues assigned to you for migrating tests. |
Description
The
InteractionModeEngine
is meant to house the functions to add aclassName
to components which will add styles when active with keyboard navigation. For example, the button components will have an outline when they are navigated with the keyboard only. It is meant to prevent these styles on hover with the mouse.Acceptance Criteria
Refactor the InteractionModeEngine away from a class. Some discovery will be required here.
Questions to answer:
Overall, how can this be moved away from a class component while retaining its functionality?
Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.
How to Contribute
Please review the contributing documentation beforehand.
Steps to Contribute:
npm run test -- -u
and include the updated tests in your commit.refactor: button component
.The text was updated successfully, but these errors were encountered: