Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Popover component tests from Enzyme to React Testing Library #813

Closed
nataliepina opened this issue Oct 12, 2022 · 2 comments
Closed

Comments

@nataliepina
Copy link
Collaborator

nataliepina commented Oct 12, 2022

Description

This issue is related to refactoring the Popover.test.tsx file tests.

We've recently been migrating our tests from Jest + Enzyme to Jest + testing-library/react to support a full migration to React 18.

You may refer to this previous PR beginning the migration for code examples - #771.

Acceptance Criteria

Refactor the test to use React Testing Library instead of Enzyme (which is no longer supported with React 18).

More information: Migrate from Enzyme

How to Contribute

Please review the contributing documentation beforehand.

Steps to Contribute:

  1. Fork the repository.
  2. Clone it to your local system.
  3. Create a new branch.
  4. Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
  5. Commit your changes. When committing be sure to prefix with the appropriate conventional commit type. For example, refactor: <component_name> tests.
  6. Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
  7. Fill out the pull request form and attach the "ready for review" label when complete.
@leonardomaier
Copy link
Contributor

@nataliepina I'm working on this one, could you assign me to it?

@mstruebing
Copy link
Contributor

Thank you @leonardomaier - if you need any help feel free to ask 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants