Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ToggleInputList component from a class to a function component #825

Closed
nataliepina opened this issue Oct 18, 2022 · 1 comment
Closed

Comments

@nataliepina
Copy link
Collaborator

nataliepina commented Oct 18, 2022

Description

This issue is related to refactoring the ToggleInputList.tsx file.

Acceptance Criteria

Refactor the component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.

Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.

How to Contribute

Please review the contributing documentation beforehand.

Steps to Contribute:

  1. Fork the repository.
  2. Clone it to your local system.
  3. Create a new branch.
  4. Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
  5. Commit your changes. When committing be sure to prefix with the appropriate conventional commit type. For example, refactor: button component.
  6. Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
  7. Fill out the pull request form and attach the "ready to review" label when complete.
@nataliepina nataliepina changed the title Refactor ToggleInputList related components from classes to functional components Refactor ToggleInputList component from a class to a function component Oct 18, 2022
@leonardomaier
Copy link
Contributor

Done here: #829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants