Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On app termination long output of "2018/10/01 11:18:47 Signal received, cancel context" messages #13

Closed
d2r2 opened this issue Oct 2, 2018 · 1 comment
Closed

On app termination long output of "2018/10/01 11:18:47 Signal received, cancel context" messages #13

d2r2 opened this issue Oct 2, 2018 · 1 comment
Labels
Priority: Critical Status: Accepted Type: Bug

Comments

@d2r2
Copy link
Owner

d2r2 commented Oct 2, 2018

As @jnovack report, app termination produce long output, which can contains hundreds/thousands of lines:

2018/10/01 11:18:47 Signal received, cancel context
2018/10/01 11:18:47 Signal received, cancel context
2018/10/01 11:18:47 Signal received, cancel context
2018/10/01 11:18:47 Signal received, cancel context

As it found each call to ReadDHTxxWithRetry left goroutine live and running inside of shell.CloseContextOnKillSignal(cancel) waiting for termination event.
@d2r2
Copy link
Owner Author

d2r2 commented Oct 2, 2018

Issue resolved in pull request #14.

@d2r2 d2r2 closed this as completed Oct 2, 2018
This was referenced Oct 2, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Status: Accepted Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d2r2