Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attr instead of style to provide defaults and facilitate overrides. #7

Closed
mbostock opened this issue May 8, 2016 · 0 comments
Closed
Assignees

Comments

@mbostock
Copy link
Member

mbostock commented May 8, 2016

This will allow us to define a default fill and stroke for ticks and the domain path, rather than requiring users to include these style rules:

.axis line {
  stroke: #000;
}

.axis path {
  fill: none;
  stroke: #000;
}

(I’m not 100% certain crispEdges should be included by default; it’s probably best to use make the defaults as minimal as possible, both for performance and to facilitate overrides.)

Related d3/d3#2102; this would also apply to the text-anchor used to position axis ticks.

@mbostock mbostock self-assigned this May 8, 2016
@mbostock mbostock changed the title Use attr instead of style to provide defaults and allow overrides. Use attr instead of style to provide defaults and facilitate overrides. May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant