d3.geoCircle

[mbostock]

https://github.com/d3/d3/blob/v3.5.17/src/geo/circle.js

[chrisuehlinger]

So in the README scaffold you checked in, you say that we might be moving d3.geoRotation() to the d3-geo-projection package. However, it (along with the spherical projection) are required for the current implementation of d3.geoCircle(). Should I take a crack at re-implementing d3.geoCircle without them or should we just include them in d3-geo.

Also, if d3.geoRotation() is getting the boot, are the "batteries included" projections like Mercator going with it?

[mbostock]

Hadn’t thought that far ahead. I forgot that it was used by d3.geoCircle. If that’s the case, probably leave it in.

[chrisuehlinger]

I've got a circle branch ready to go once rotation merges. However, in the README you seemed unsure whether you wanted to rename circle.origin and circle.angle to circle.center and circle.radius. Do you want me to rename them (I'm personally in favor, though I get why they were called those names originally) or do you want to think about it a bit longer?

[mbostock]

Sure, a rename sounds fine.

[mbostock]

Fixed by @chrisuehlinger in #21.